Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing Issue 101. #103

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Addressing Issue 101. #103

merged 5 commits into from
Feb 21, 2025

Conversation

markpbaggett
Copy link
Collaborator

@markpbaggett markpbaggett commented Feb 20, 2025 •
edited
Loading

What Does this Do

This does several things.

  1. replaces the default redirect behavior so that versionless requests are proxied to the request for the latest presentation API version rather than redirecting as a 302. It does this by calling function related to the decorator of the latest API version.
  2. makes version 2 manifests have an @id with the version number in it.
  3. ensures the helper uses the versionless url.
  4. updates the docs.
  5. udates or replaces tests to reflect these changes.

@markpbaggett markpbaggett changed the title Issue 101 Addressing Issue 101. Feb 20, 2025
glenrobson
glenrobson reviewed Feb 20, 2025
View reviewed changes
@markpbaggett markpbaggett marked this pull request as ready for review February 21, 2025 00:16
glenrobson
glenrobson approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@glenrobson glenrobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@glenrobson glenrobson merged commit 5058046 into main Feb 21, 2025
4 checks passed
@glenrobson glenrobson deleted the issue_101 branch February 21, 2025 00:23
@glenrobson glenrobson mentioned this pull request Feb 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glenrobson glenrobson glenrobson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markpbaggett @glenrobson